Kernel/Upstreaming

From Openmoko

(Difference between revisions)
Jump to: navigation, search
 
(41 intermediate revisions by 5 users not shown)
Line 1: Line 1:
 
Random notes on SHR kernel patches (v2.6.39.4..shr-2.6.39-nodrm).
 
Random notes on SHR kernel patches (v2.6.39.4..shr-2.6.39-nodrm).
  
= [https://gitorious.org/shr/linux/commit/f58597e68f36da7d4f4dec08520d3e12258addf2 <nowiki>ARM: s3c24xx: Set ARCH_NR_GPIOS according to the selected SoC types.</nowiki>] =
+
= [https://gitorious.org/shr/linux/commit/f58597e68f36da7d4f4dec08520d3e12258addf2?format=patch <nowiki>ARM: s3c24xx: Set ARCH_NR_GPIOS according to the selected SoC types.</nowiki>] =
 
  lindi: bugfix/feature. sounds sensible. s3c specific
 
  lindi: bugfix/feature. sounds sensible. s3c specific
= [https://gitorious.org/shr/linux/commit/56ee57980e903f6fbcac9fd35d0410b7bb363ae5 <nowiki>s3c24xx: Fix level irqs on external interrupts.</nowiki>] =
+
Seems to be at least partially upstream since v3.2-rc1: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=8a8ab2e64e09b56dc1324fd2f7da12346166cad1
 +
 
 +
= [https://gitorious.org/shr/linux/commit/56ee57980e903f6fbcac9fd35d0410b7bb363ae5?format=patch <nowiki>s3c24xx: Fix level irqs on external interrupts.</nowiki>] =
 
  lindi: bugfix. s3c specific
 
  lindi: bugfix. s3c specific
= [https://gitorious.org/shr/linux/commit/f3f81740815d9207356cb4fcddc3196c7cbadb72 <nowiki>mtd: s3c2410_nand: Add config option to disable hw ecc at runtime</nowiki>] =
+
= [https://gitorious.org/shr/linux/commit/f3f81740815d9207356cb4fcddc3196c7cbadb72?format=patch <nowiki>mtd: s3c2410_nand: Add config option to disable hw ecc at runtime</nowiki>] =
  lindi: feature. simple. I personally can live without nand.  
+
  lindi: feature. simple. I personally can live without nand.
= [https://gitorious.org/shr/linux/commit/25db4ec44e13d7934100eab7860a9e38d5644007 <nowiki>Add s3c24xx_serial_console_set_silence</nowiki>] =
+
lindi: Lars tried to upstream but it was rejected:
  lindi: What is this for? To allow using serial console and GSM on the same serial port? Who needs this anymore?
+
> Lars-Peter Clausen <lars@metafoo.de> writes:
= [https://gitorious.org/shr/linux/commit/d38596283fd7b1c92138ac44352f08bb24636e71 <nowiki>Add c fiq handler.</nowiki>] =
+
>> Not quite. I had for example a 5 liner rejected by a maintainer saying he can't
 +
>> accept any code which adds new platform code to ARM.
 +
lindi: however that appears to have been a misunderstanding and this can be resent
 +
 
 +
= [https://gitorious.org/shr/linux/commit/25db4ec44e13d7934100eab7860a9e38d5644007?format=patch <nowiki>Add s3c24xx_serial_console_set_silence</nowiki>] =
 +
  lindi: openmoko specific. only for gta01: to have serial console and GSM on the same port.
 +
= [https://gitorious.org/shr/linux/commit/d38596283fd7b1c92138ac44352f08bb24636e71?format=patch <nowiki>Add c fiq handler.</nowiki>] =
 
  lindi: feature. tricky! Used by battery hdq queries (temperature, current, capacity etc.) and vibrator. Should just rewrite them in assembler?
 
  lindi: feature. tricky! Used by battery hdq queries (temperature, current, capacity etc.) and vibrator. Should just rewrite them in assembler?
= [https://gitorious.org/shr/linux/commit/d3048278388b0908e179882587a8b6fcd95f2f50 <nowiki>Add glamo driver.</nowiki>] =
+
lindi: http://osdevnotes.blogspot.com/2011/10/fiq-debugger-redux.html mentions that google has something similar for their FIQ debugger.
 +
= [https://gitorious.org/shr/linux/commit/d3048278388b0908e179882587a8b6fcd95f2f50?format=patch <nowiki>Add glamo driver.</nowiki>] =
 
  lindi: feature. tricky!! This does not include the DRM/3D bits but it is enough for me.
 
  lindi: feature. tricky!! This does not include the DRM/3D bits but it is enough for me.
= [https://gitorious.org/shr/linux/commit/df2b549c2cd45742d7ea63b159b5a23cccd54c9e <nowiki>ARM: gta02: Add LED support</nowiki>] =
+
= [https://gitorious.org/shr/linux/commit/df2b549c2cd45742d7ea63b159b5a23cccd54c9e?format=patch <nowiki>ARM: gta02: Add LED support</nowiki>] =
 
  lindi: feature. openmoko specific. simple.
 
  lindi: feature. openmoko specific. simple.
= [https://gitorious.org/shr/linux/commit/ec9382726b6c58494210d0c361b33a0617a39316 <nowiki>gta02: Disable hardware ECC unless we get instructed to enable it</nowiki>] =
+
lindi: could this be the next candidate for upstreaming? Is there anything controversial here? has somebody already tried to upstream this?
 +
lindi: there's a lot of extra whitespace changes, probably because the patch has been rebased many times?
 +
 
 +
= [https://gitorious.org/shr/linux/commit/ec9382726b6c58494210d0c361b33a0617a39316?format=patch <nowiki>gta02: Disable hardware ECC unless we get instructed to enable it</nowiki>] =
 
  lindi: openmoko specific. nand. simple.
 
  lindi: openmoko specific. nand. simple.
= [https://gitorious.org/shr/linux/commit/caa1bc2b4331544a7b3835635e98b7f232dd5e59 <nowiki>gta02: Remove usage of pcf50633 gpio api</nowiki>] =
+
= [https://gitorious.org/shr/linux/commit/caa1bc2b4331544a7b3835635e98b7f232dd5e59?format=patch <nowiki>gta02: Remove usage of pcf50633 gpio api</nowiki>] =
 
  lindi: openmoko specific. cleanup.
 
  lindi: openmoko specific. cleanup.
= [https://gitorious.org/shr/linux/commit/4ed282d67df719b6c86ff8e5a180f826cbb7fff7 <nowiki>s3c2440: gta02: Configure pcf50633 gpios.</nowiki>] =
+
= [https://gitorious.org/shr/linux/commit/4ed282d67df719b6c86ff8e5a180f826cbb7fff7?format=patch <nowiki>s3c2440: gta02: Configure pcf50633 gpios.</nowiki>] =
 
  lindi: openmoko specific.
 
  lindi: openmoko specific.
= [https://gitorious.org/shr/linux/commit/146f7ec553fae1e7655cde17802d23b0c6e14a27 <nowiki>ARM: s3c2440: GTA02: Select SPARSE_IRQ</nowiki>] =
+
= [https://gitorious.org/shr/linux/commit/146f7ec553fae1e7655cde17802d23b0c6e14a27?format=patch <nowiki>ARM: s3c2440: GTA02: Select SPARSE_IRQ</nowiki>] =
 
  lindi: openmoko specific. simple.
 
  lindi: openmoko specific. simple.
= [https://gitorious.org/shr/linux/commit/9bd9379698b85d2baf7b98b5bf59f65a7e709b55 <nowiki>gta02: Add notify handler to probe device children</nowiki>] =
+
= [https://gitorious.org/shr/linux/commit/9bd9379698b85d2baf7b98b5bf59f65a7e709b55?format=patch <nowiki>gta02: Add notify handler to probe device children</nowiki>] =
 
  lindi: openmoko specific. feature.
 
  lindi: openmoko specific. feature.
= [https://gitorious.org/shr/linux/commit/0dace283ee622f2cdfa78dac1deee64038841309 <nowiki>gta02: Add bt power management device</nowiki>] =
+
= [https://gitorious.org/shr/linux/commit/0dace283ee622f2cdfa78dac1deee64038841309?format=patch <nowiki>gta02: Add bt power management device</nowiki>] =
 +
lindi: openmoko specific. simple. is this the right API to use? could we abuse rfkill? what do the androids/n900/N9 use?
 +
= [https://gitorious.org/shr/linux/commit/5a7eaa51c3e7298416d1faf17ba96678498b6a7e?format=patch <nowiki>gta02: Add gps power management device</nowiki>] =
 
  lindi: openmoko specific. simple.
 
  lindi: openmoko specific. simple.
= [https://gitorious.org/shr/linux/commit/5a7eaa51c3e7298416d1faf17ba96678498b6a7e <nowiki>gta02: Add gps power management device</nowiki>] =
+
= [https://gitorious.org/shr/linux/commit/c2742ff04d32db3d287c0bc4f7ab090fc957ee49?format=patch <nowiki>gta02: Add gsm power management device</nowiki>] =
 
  lindi: openmoko specific. simple.
 
  lindi: openmoko specific. simple.
= [https://gitorious.org/shr/linux/commit/c2742ff04d32db3d287c0bc4f7ab090fc957ee49 <nowiki>gta02: Add gsm power management device</nowiki>] =
+
= [https://gitorious.org/shr/linux/commit/ef27e9c481964789fa7ed703b9d7d53a00ad6036?format=patch <nowiki>gta02: Add wlan power management device</nowiki>] =
 
  lindi: openmoko specific. simple.
 
  lindi: openmoko specific. simple.
= [https://gitorious.org/shr/linux/commit/ef27e9c481964789fa7ed703b9d7d53a00ad6036 <nowiki>gta02: Add wlan power management device</nowiki>] =
+
= [https://gitorious.org/shr/linux/commit/2dc04b2d325cea146f4605cdbc885126ec8c0859?format=patch <nowiki>gta02: Add glamo device</nowiki>] =
lindi: openmoko specific. simple.
+
= [https://gitorious.org/shr/linux/commit/2dc04b2d325cea146f4605cdbc885126ec8c0859 <nowiki>gta02: Add glamo device</nowiki>] =
+
 
  lindi: openmoko specific. relatively simple, real trouble is in the glamo driver itself
 
  lindi: openmoko specific. relatively simple, real trouble is in the glamo driver itself
= [https://gitorious.org/shr/linux/commit/cf18c7ef4b91239ff51929d60173afa26627ba51 <nowiki>Add jbt device.</nowiki>] =
+
= [https://gitorious.org/shr/linux/commit/cf18c7ef4b91239ff51929d60173afa26627ba51?format=patch <nowiki>Add jbt device.</nowiki>] =
  lindi: openmoko specific. backlight?
+
  lindi: openmoko specific. LCD control?
= [https://gitorious.org/shr/linux/commit/3db6ef4d2bf156826a3c9ee7bd6be334d6696662 <nowiki>gta02: Add fiq handler</nowiki>] =
+
= [https://gitorious.org/shr/linux/commit/3db6ef4d2bf156826a3c9ee7bd6be334d6696662?format=patch <nowiki>gta02: Add fiq handler</nowiki>] =
 
  lindi: openmoko specific. depends on the tricky fiq support above.
 
  lindi: openmoko specific. depends on the tricky fiq support above.
= [https://gitorious.org/shr/linux/commit/d639c61f8338dcc221f88f350e2804e12e2dfaaf <nowiki>gta02: Add battery driver</nowiki>] =
+
= [https://gitorious.org/shr/linux/commit/d639c61f8338dcc221f88f350e2804e12e2dfaaf?format=patch <nowiki>gta02: Add battery driver</nowiki>] =
 
  lindi: openmoko specific. depends on the tricky fiq support above.
 
  lindi: openmoko specific. depends on the tricky fiq support above.
= [https://gitorious.org/shr/linux/commit/6afb7d88356ab738bb469850854df6c4c31f3f3f <nowiki>gta02: add support for platform_battery</nowiki>] =
+
lindi: mach-gta02.c:595: warning: ‘gta02_get_charger_online_status’ defined but not used
 +
 
 +
= [https://gitorious.org/shr/linux/commit/6afb7d88356ab738bb469850854df6c4c31f3f3f?format=patch <nowiki>gta02: add support for platform_battery</nowiki>] =
 
  lindi: openmoko specific. simple.
 
  lindi: openmoko specific. simple.
= [https://gitorious.org/shr/linux/commit/2111dc5154f0134b173ef122609d7b0e6fb0f6a0 <nowiki>Add atheros sdio ids.</nowiki>] =
+
= [https://gitorious.org/shr/linux/commit/2111dc5154f0134b173ef122609d7b0e6fb0f6a0?format=patch <nowiki>Add atheros sdio ids.</nowiki>] =
  lindi: trivial.
+
  lindi: trivial. why does AR6003 define this in drivers/net/wireless/ath/ath6kl/hif.h and not this common file?
= [https://gitorious.org/shr/linux/commit/81c7116b8418aa499ebea9755fc586e8bfc6d91e <nowiki>Add ar6000 wireless driver.</nowiki>] =
+
= [https://gitorious.org/shr/linux/commit/81c7116b8418aa499ebea9755fc586e8bfc6d91e?format=patch <nowiki>Add ar6000 wireless driver.</nowiki>] =
 
  lindi: tricky! probably can never be mainlined. Maybe we can build it as a separate module package in debian?
 
  lindi: tricky! probably can never be mainlined. Maybe we can build it as a separate module package in debian?
= [https://gitorious.org/shr/linux/commit/4e11662e7b95b1a8cdee1f5af9dc5ec49ce3c129 <nowiki>Add jbt6k74 display driver.</nowiki>] =
+
lindi: gcc seems to inline a lot and use a lot of stack here: ioctl.c:2531: warning: the frame size of 1888 bytes is larger than 1024 bytes
 +
 
 +
From #ath6kl on freenode:
 +
<pabs3> kvalo: does ath6kl support AR6001/AR6002?
 +
<kvalo> pabs3: no
 +
<pabs3> kvalo: do you think it is feasible to add support for them, or are they completely different?
 +
<kvalo> pabs3: I haven't even seen either of them so I'm not qualified to answer :)
 +
<pabs3> ok
 +
 
 +
= [https://gitorious.org/shr/linux/commit/4e11662e7b95b1a8cdee1f5af9dc5ec49ce3c129?format=patch <nowiki>Add jbt6k74 display driver.</nowiki>] =
 
  lindi: feature. quite essential. does not look too tricky.
 
  lindi: feature. quite essential. does not look too tricky.
= [https://gitorious.org/shr/linux/commit/82dfe46f68342b3139b4df33cf3f782ab6d52dd9 <nowiki>LEDS: leds-pwm: Add init, notfiy and exit callbacks</nowiki>] =
+
= [https://gitorious.org/shr/linux/commit/82dfe46f68342b3139b4df33cf3f782ab6d52dd9?format=patch <nowiki>LEDS: leds-pwm: Add init, notfiy and exit callbacks</nowiki>] =
 
  lindi: feature. not sure how easy this is to mainline
 
  lindi: feature. not sure how easy this is to mainline
= [https://gitorious.org/shr/linux/commit/8e99225f5a165b20e25611db3486058d7f4e9dc1 <nowiki>RTC: PCF50633: Don't request update IRQ</nowiki>] =
+
= [https://gitorious.org/shr/linux/commit/8e99225f5a165b20e25611db3486058d7f4e9dc1?format=patch <nowiki>RTC: PCF50633: Don't request update IRQ</nowiki>] =
 
  lindi: safe cleanup?
 
  lindi: safe cleanup?
= [https://gitorious.org/shr/linux/commit/0a304203ac7daf36070f8fecd8974bfaf84d9df6 <nowiki>pcf50633-gpio: Add gpiolib support.</nowiki>] =
+
lindi: seems to be upstream already in 3.0.0 as 3d62b8f59bb8bd08d8e3df3ab3174aab2971d6e6
 +
 
 +
= [https://gitorious.org/shr/linux/commit/0a304203ac7daf36070f8fecd8974bfaf84d9df6?format=patch <nowiki>pcf50633-gpio: Add gpiolib support.</nowiki>] =
 
  lindi: feature. has some useless whitespace changes. gpio stuff which I don't really understand
 
  lindi: feature. has some useless whitespace changes. gpio stuff which I don't really understand
= [https://gitorious.org/shr/linux/commit/22ce0c31d823e002859fe5ef50f17905ce90471b <nowiki>pcf50633: Move pcf50633-gpio driver to the gpio drivers folder</nowiki>] =
+
lindi: pcf50633-gpio.c:197: warning: ignoring return value of ‘gpiochip_remove’, declared with attribute warn_
 +
 
 +
= [https://gitorious.org/shr/linux/commit/22ce0c31d823e002859fe5ef50f17905ce90471b?format=patch <nowiki>pcf50633: Move pcf50633-gpio driver to the gpio drivers folder</nowiki>] =
 
  lindi: just moves a file
 
  lindi: just moves a file
= [https://gitorious.org/shr/linux/commit/e583591037796f962d07e935b2a1bdd0f89a61fb <nowiki>MFD: pcf50633: Use mfd cells to register  
+
= [https://gitorious.org/shr/linux/commit/e583591037796f962d07e935b2a1bdd0f89a61fb?format=patch <nowiki>MFD: pcf50633: Use mfd cells to register  
 
child devices</nowiki>] =
 
child devices</nowiki>] =
 
  lindi: cleanup? No idea how tricky this really is
 
  lindi: cleanup? No idea how tricky this really is
= [https://gitorious.org/shr/linux/commit/780da55e2ad7f9d934e7452fba4340a5f9575a32 <nowiki>MFD: pcf50633: Use the genirq for irq handling</nowiki>] =
+
= [https://gitorious.org/shr/linux/commit/780da55e2ad7f9d934e7452fba4340a5f9575a32?format=patch <nowiki>MFD: pcf50633: Use the genirq for irq handling</nowiki>] =
 
  lindi: has again extra whitespace changes. I guess genirq is some more abstract way to handle IRQs? Can not really judge how tricky this is.
 
  lindi: has again extra whitespace changes. I guess genirq is some more abstract way to handle IRQs? Can not really judge how tricky this is.
= [https://gitorious.org/shr/linux/commit/3e77986a22550a8df84d9e78ddbc281488bf1120 <nowiki>power: implement platform battery driver</nowiki>] =
+
= [https://gitorious.org/shr/linux/commit/3e77986a22550a8df84d9e78ddbc281488bf1120?format=patch <nowiki>power: implement platform battery driver</nowiki>] =
 
  lindi: feature. we can live without this if bq27x00 is mainlined or vice versa.
 
  lindi: feature. we can live without this if bq27x00 is mainlined or vice versa.
= [https://gitorious.org/shr/linux/commit/d09e21824bacd5f9ac0285c14c6ddc2d79b96608 <nowiki>Define machine_is_neo1973_gta01()</nowiki>] =
+
= [https://gitorious.org/shr/linux/commit/d09e21824bacd5f9ac0285c14c6ddc2d79b96608?format=patch <nowiki>Define machine_is_neo1973_gta01()</nowiki>] =
 
  lindi: trivial
 
  lindi: trivial
= [https://gitorious.org/shr/linux/commit/a73311169fef3284647f3c80748c644abe3c72fb <nowiki>glamo-mci: revert changes for Per's patchset</nowiki>] =
+
= [https://gitorious.org/shr/linux/commit/a73311169fef3284647f3c80748c644abe3c72fb?format=patch <nowiki>glamo-mci: revert changes for Per's patchset</nowiki>] =
 
  lindi: glamo stuff, no idea
 
  lindi: glamo stuff, no idea
= [https://gitorious.org/shr/linux/commit/833339cd47295e86e0ca8c838e8997a24ababf6c <nowiki>nand/s3c2410: add mising badblocksbits value</nowiki>] =
+
= [https://gitorious.org/shr/linux/commit/833339cd47295e86e0ca8c838e8997a24ababf6c?format=patch <nowiki>nand/s3c2410: add mising badblocksbits value</nowiki>] =
  lindi: bugfix. trivial.
+
  lindi: bugfix. trivial.  
= [https://gitorious.org/shr/linux/commit/919ad8a33847d10bb2b6b4f9bb24702346455f1f <nowiki>Openmoko resume reason sysfs node ported from 2.6.29</nowiki>] =
+
lindi: it seems this was broken in 2.6.36 and fixed again in 3.0.0 but differently: 26d9be11485ea8c1102c3e8eaa7667412eef4950
 +
= [https://gitorious.org/shr/linux/commit/919ad8a33847d10bb2b6b4f9bb24702346455f1f?format=patch <nowiki>Openmoko resume reason sysfs node ported from 2.6.29</nowiki>] =
 
  lindi: feature. I personally need this a lot so that I can differentiate between RTC and GSM wakeups
 
  lindi: feature. I personally need this a lot so that I can differentiate between RTC and GSM wakeups
= [https://gitorious.org/shr/linux/commit/dd73aa36cb4d37d200aead95310df58cfec784d3 <nowiki>glamo-display: fix WSOD for 242 timming</nowiki>] =
+
= [https://gitorious.org/shr/linux/commit/dd73aa36cb4d37d200aead95310df58cfec784d3?format=patch <nowiki>glamo-display: fix WSOD for 242 timming</nowiki>] =
 
  lindi: openmoko specific. glamo hack. Who said 2-4-2 timings have no drawbacks? ;-)
 
  lindi: openmoko specific. glamo hack. Who said 2-4-2 timings have no drawbacks? ;-)
= [https://gitorious.org/shr/linux/commit/5c7e36859e8e28f9b56a2cb3ceb0ab2c3d079f96 <nowiki>Enable powering off after 8s POWER press</nowiki>] =
+
gena2x: This is not original name for patch! And not true. I do not know why radek maned it with this way, but actually it JUST fixes WSOD with all kind of timings. Please rename it.
  lindi: openmoko specific. feature. simple. I personally can live without this.
+
 
= [https://gitorious.org/shr/linux/commit/ba207d46b7857f6cae1368f0e62e611eb773505c <nowiki>gta02: add support for usb host mode</nowiki>] =
+
= [https://gitorious.org/shr/linux/commit/5c7e36859e8e28f9b56a2cb3ceb0ab2c3d079f96?format=patch <nowiki>Enable powering off after 8s POWER press</nowiki>] =
 +
  lindi: openmoko specific. feature. simple. I personally don't really like this much however this should be easy to upstream.
 +
= [https://gitorious.org/shr/linux/commit/ba207d46b7857f6cae1368f0e62e611eb773505c?format=patch <nowiki>gta02: add support for usb host mode</nowiki>] =
 
  lindi: openmoko specific feature. looks quite simple.
 
  lindi: openmoko specific feature. looks quite simple.
= [https://gitorious.org/shr/linux/commit/3066c8798168cb31af999e9d55bca2b445e27cdb <nowiki>ar6000_delay.patch</nowiki>] =
+
= [https://gitorious.org/shr/linux/commit/3066c8798168cb31af999e9d55bca2b445e27cdb?format=patch <nowiki>ar6000_delay.patch</nowiki>] =
 
  lindi: atheros wifi hack
 
  lindi: atheros wifi hack
= [https://gitorious.org/shr/linux/commit/b3f60f3ed24f503bda64aabf94b62053379c9ca9 <nowiki>wm8753: use snd_soc_jack on neo1973</nowiki>] =
+
= [https://gitorious.org/shr/linux/commit/b3f60f3ed24f503bda64aabf94b62053379c9ca9?format=patch <nowiki>wm8753: use snd_soc_jack on neo1973</nowiki>] =
 
  lindi: openmoko specific. gta01-only?
 
  lindi: openmoko specific. gta01-only?
= [https://gitorious.org/shr/linux/commit/d5d5ee9c07ee06174f06255ae3141c368ca48f6a <nowiki>Fix high power consumption in suspend</nowiki>] =
+
= [https://gitorious.org/shr/linux/commit/d5d5ee9c07ee06174f06255ae3141c368ca48f6a?format=patch <nowiki>Fix high power consumption in suspend</nowiki>] =
  lindi: openmoko specific. bugfix. simple.
+
  lindi: openmoko specific. bugfix. simple. this should be a good candidate for upstreaming first?
= [https://gitorious.org/shr/linux/commit/084e5cd3284d499e3c4eb86f26042e7d72df2266 <nowiki>Force GPS power up on resume if it were powered up on suspend</nowiki>] =
+
lindi: gena2x, this needs a better commit message
 +
 
 +
= [https://gitorious.org/shr/linux/commit/084e5cd3284d499e3c4eb86f26042e7d72df2266?format=patch <nowiki>Force GPS power up on resume if it were powered up on suspend</nowiki>] =
 
  lindi: openmoko specific. Is this needed at all with qi? (My guess is no, its resume path does not touch serial ports)
 
  lindi: openmoko specific. Is this needed at all with qi? (My guess is no, its resume path does not touch serial ports)
= [https://gitorious.org/shr/linux/commit/edcc8410bc93dcc06b69d57e8b7b47756124cd1e <nowiki>lis302dl accelerometer driver</nowiki>] =
+
= [https://gitorious.org/shr/linux/commit/edcc8410bc93dcc06b69d57e8b7b47756124cd1e?format=patch <nowiki>lis302dl accelerometer driver</nowiki>] =
 
  lindi: openmoko specific. feature. hard to say how tricky this is. I can personally live without accelerometers.
 
  lindi: openmoko specific. feature. hard to say how tricky this is. I can personally live without accelerometers.
= [https://gitorious.org/shr/linux/commit/02e9ff6da8f66701739b5beac43200eb3e0acbd7 <nowiki>input: lis302dl: fix the resume path</nowiki>] =
+
Paul: upstream has a different driver for the hardware: http://lwn.net/Articles/304326/
 +
= [https://gitorious.org/shr/linux/commit/02e9ff6da8f66701739b5beac43200eb3e0acbd7?format=patch <nowiki>input: lis302dl: fix the resume path</nowiki>] =
 
  lindi: openmoko specific. bugfix to accelerometer support.
 
  lindi: openmoko specific. bugfix to accelerometer support.
= [https://gitorious.org/shr/linux/commit/10b4b78dc2081caff1239f229e08a7e829ed3c7d <nowiki>lis302dl: use ABS events rather then REL events</nowiki>] =
+
= [https://gitorious.org/shr/linux/commit/10b4b78dc2081caff1239f229e08a7e829ed3c7d?format=patch <nowiki>lis302dl: use ABS events rather then REL events</nowiki>] =
 
  lindi: openmoko specific. bugfix to accelerometer support.
 
  lindi: openmoko specific. bugfix to accelerometer support.
= [https://gitorious.org/shr/linux/commit/9668f02fe2af9dd880d5f83f95bd07bb2d963c56 <nowiki>Fix compile error for gta02 accelerometer.</nowiki>] =
+
= [https://gitorious.org/shr/linux/commit/9668f02fe2af9dd880d5f83f95bd07bb2d963c56?format=patch <nowiki>Fix compile error for gta02 accelerometer.</nowiki>] =
 
  lindi: openmoko specific. trivial bugfix to accelerometer support. Why not rebase this to the patch?
 
  lindi: openmoko specific. trivial bugfix to accelerometer support. Why not rebase this to the patch?
= [https://gitorious.org/shr/linux/commit/f0e6a6317de2567383a543a545cf50e58b3caa3d <nowiki>tslib relies on ts pressures events so this hack is needed to get tslib stuff working</nowiki>] =
+
= [https://gitorious.org/shr/linux/commit/f0e6a6317de2567383a543a545cf50e58b3caa3d?format=patch <nowiki>tslib relies on ts pressures events so this hack is needed to get tslib stuff working</nowiki>] =
 
  lindi: s3c specific. hack? I personally can live with evdev if this really only affects tslib.
 
  lindi: s3c specific. hack? I personally can live with evdev if this really only affects tslib.
= [https://gitorious.org/shr/linux/commit/b05f074d5eb6f77cefcef35f7f2b2aaeb27af069 <nowiki>touchscreen: ignore unexpected interrupts</nowiki>] =
+
Paul: hm, worth investigating more: is not returning pressure at all a valid thing to do for a TS driver?
 +
Heiko Stübner <heiko@sntech.de>:
 +
  As I'm currently also working on a touchscreen driver I came upon a lot of
 +
  discussion and documentation about the handling of pressure values.
 +
  In the end a driver should not use the pressure property at all if it can't
 +
  provide meaningfull pressure data (i.e. more than 0 and 1) and tslib should be
 +
  "long fixed", if one does not use an ancient version.
 +
 
 +
= [https://gitorious.org/shr/linux/commit/b05f074d5eb6f77cefcef35f7f2b2aaeb27af069?format=patch <nowiki>touchscreen: ignore unexpected interrupts</nowiki>] =
 
  lindi: s3c specific. bugfix? hard to say how ready this is for mainlining.
 
  lindi: s3c specific. bugfix? hard to say how ready this is for mainlining.
= [https://gitorious.org/shr/linux/commit/1f3750e2cf3895b269589495147416c61ba523c5 <nowiki>s3c2410_ts: jitter less touchscreen for glamo, version 4</nowiki>] =
+
= [https://gitorious.org/shr/linux/commit/1f3750e2cf3895b269589495147416c61ba523c5?format=patch <nowiki>s3c2410_ts: jitter less touchscreen for glamo, version 4</nowiki>] =
  lindi: openmoko specific. quite essential. why does touchscreen depend on glamo?
+
  lindi: openmoko specific. quite essential. hack: read ts during vblank?
= [https://gitorious.org/shr/linux/commit/74c481b35be9bf9b7d512de6942c7be345a7db47 <nowiki>wm8753: allow setting DAI mode even while pcm is active</nowiki>] =
+
gena2x: it slows down pixclock to read jitterless data. it does that while blank so screen has no artefacts. may be it is possible to do that while blank without slowing pixclock, even that we have no VSYNC-like interrupt we should be able to calculate exact time of VSYNC because pixclock is constant and we always know current position. But this doesn't solve only major concern of this patch - it introduces link (via callbacks) between glamo and ts.
  lindi: bugfix. should be easy to mainline.
+
 
= [https://gitorious.org/shr/linux/commit/4f1ae92f97c4aaad16567a5101c8b668893a9c91 <nowiki>Workaround toolchain bug: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48783</nowiki>] =
+
= [https://gitorious.org/shr/linux/commit/74c481b35be9bf9b7d512de6942c7be345a7db47?format=patch <nowiki>wm8753: allow setting DAI mode even while pcm is active</nowiki>] =
 +
  lindi: bugfix. should be easy to mainline. This basically fixes a bug introduced in 338ee25393a5627e8ded5819147f98b919656ce9 that was mainlined to 2.6.39
 +
lindi: is there some other driver that needs a similar fix? tlv320dac33.c seems to have a similar if (dac33->fifo_mode == ucontrol->value.integer.value[0]) return 0;
 +
lindi: why does this return 1?
 +
lindi: this seems to be called from snd_ctl_elem_write. If we return 1 then it calls snd_ctl_notify, what does this mean?
 +
lindi-_> gena2x_ptr: "return 1" is a bug in that patch, it needs to be "return 0"
 +
lindi-_> gena2x_ptr: easy to see
 +
lindi-_> gena2x_ptr: strace alsamixer
 +
lindi-_> gena2x_ptr: then while true; do alsactl restore -f somestate; done
 +
lindi-_> gena2x_ptr: alsamixer gets spammed by bogus DAI change events
 +
lindi-_> gena2x_ptr: no other alsa control sends notifications ion this test
 +
lindi: sent upstream: http://mailman.alsa-project.org/pipermail/alsa-devel/2011-November/046036.html
 +
lindi: ACCEPTED UPSTREAM: http://mailman.alsa-project.org/pipermail/alsa-devel/2011-November/046059.html
 +
 
 +
= [https://gitorious.org/shr/linux/commit/4f1ae92f97c4aaad16567a5101c8b668893a9c91?format=patch <nowiki>Workaround toolchain bug: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48783</nowiki>] =
 
  lindi: trivial. Occurs with gcc 4.4 but not 4.6 anymore. No need to mainline :-)
 
  lindi: trivial. Occurs with gcc 4.4 but not 4.6 anymore. No need to mainline :-)
= [https://gitorious.org/shr/linux/commit/098ed461036a5d9ba027b62c18a85622a055f63d <nowiki>First attempt at fixing openmoko bug #2478</nowiki>] =
+
= [https://gitorious.org/shr/linux/commit/098ed461036a5d9ba027b62c18a85622a055f63d?format=patch <nowiki>First attempt at fixing openmoko bug #2478</nowiki>] =
  lindi: openmoko specific. bugfix. not yet ready.
+
  lindi: openmoko specific. bugfix. not yet ready. See http://docs.openmoko.org/trac/ticket/2478
 +
 
 +
[[Category:Kernel]]

Latest revision as of 10:14, 25 January 2012

Random notes on SHR kernel patches (v2.6.39.4..shr-2.6.39-nodrm).

Contents

[edit] ARM: s3c24xx: Set ARCH_NR_GPIOS according to the selected SoC types.

lindi: bugfix/feature. sounds sensible. s3c specific
Seems to be at least partially upstream since v3.2-rc1: http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=8a8ab2e64e09b56dc1324fd2f7da12346166cad1

[edit] s3c24xx: Fix level irqs on external interrupts.

lindi: bugfix. s3c specific

[edit] mtd: s3c2410_nand: Add config option to disable hw ecc at runtime

lindi: feature. simple. I personally can live without nand.
lindi: Lars tried to upstream but it was rejected:
> Lars-Peter Clausen <lars@metafoo.de> writes:
>> Not quite. I had for example a 5 liner rejected by a maintainer saying he can't
>> accept any code which adds new platform code to ARM.
lindi: however that appears to have been a misunderstanding and this can be resent

[edit] Add s3c24xx_serial_console_set_silence

lindi: openmoko specific. only for gta01: to have serial console and GSM on the same port.

[edit] Add c fiq handler.

lindi: feature. tricky! Used by battery hdq queries (temperature, current, capacity etc.) and vibrator. Should just rewrite them in assembler?
lindi: http://osdevnotes.blogspot.com/2011/10/fiq-debugger-redux.html mentions that google has something similar for their FIQ debugger.

[edit] Add glamo driver.

lindi: feature. tricky!! This does not include the DRM/3D bits but it is enough for me.

[edit] ARM: gta02: Add LED support

lindi: feature. openmoko specific. simple.
lindi: could this be the next candidate for upstreaming? Is there anything controversial here? has somebody already tried to upstream this?
lindi: there's a lot of extra whitespace changes, probably because the patch has been rebased many times?

[edit] gta02: Disable hardware ECC unless we get instructed to enable it

lindi: openmoko specific. nand. simple.

[edit] gta02: Remove usage of pcf50633 gpio api

lindi: openmoko specific. cleanup.

[edit] s3c2440: gta02: Configure pcf50633 gpios.

lindi: openmoko specific.

[edit] ARM: s3c2440: GTA02: Select SPARSE_IRQ

lindi: openmoko specific. simple.

[edit] gta02: Add notify handler to probe device children

lindi: openmoko specific. feature.

[edit] gta02: Add bt power management device

lindi: openmoko specific. simple. is this the right API to use? could we abuse rfkill? what do the androids/n900/N9 use?

[edit] gta02: Add gps power management device

lindi: openmoko specific. simple.

[edit] gta02: Add gsm power management device

lindi: openmoko specific. simple.

[edit] gta02: Add wlan power management device

lindi: openmoko specific. simple.

[edit] gta02: Add glamo device

lindi: openmoko specific. relatively simple, real trouble is in the glamo driver itself

[edit] Add jbt device.

lindi: openmoko specific. LCD control?

[edit] gta02: Add fiq handler

lindi: openmoko specific. depends on the tricky fiq support above.

[edit] gta02: Add battery driver

lindi: openmoko specific. depends on the tricky fiq support above.
lindi: mach-gta02.c:595: warning: ‘gta02_get_charger_online_status’ defined but not used

[edit] gta02: add support for platform_battery

lindi: openmoko specific. simple.

[edit] Add atheros sdio ids.

lindi: trivial. why does AR6003 define this in drivers/net/wireless/ath/ath6kl/hif.h and not this common file?

[edit] Add ar6000 wireless driver.

lindi: tricky! probably can never be mainlined. Maybe we can build it as a separate module package in debian?
lindi: gcc seems to inline a lot and use a lot of stack here: ioctl.c:2531: warning: the frame size of 1888 bytes is larger than 1024 bytes
From #ath6kl on freenode:
<pabs3> kvalo: does ath6kl support AR6001/AR6002?
<kvalo> pabs3: no
<pabs3> kvalo: do you think it is feasible to add support for them, or are they completely different?
<kvalo> pabs3: I haven't even seen either of them so I'm not qualified to answer :)
<pabs3> ok

[edit] Add jbt6k74 display driver.

lindi: feature. quite essential. does not look too tricky.

[edit] LEDS: leds-pwm: Add init, notfiy and exit callbacks

lindi: feature. not sure how easy this is to mainline

[edit] RTC: PCF50633: Don't request update IRQ

lindi: safe cleanup?
lindi: seems to be upstream already in 3.0.0 as 3d62b8f59bb8bd08d8e3df3ab3174aab2971d6e6

[edit] pcf50633-gpio: Add gpiolib support.

lindi: feature. has some useless whitespace changes. gpio stuff which I don't really understand
lindi: pcf50633-gpio.c:197: warning: ignoring return value of ‘gpiochip_remove’, declared with attribute warn_

[edit] pcf50633: Move pcf50633-gpio driver to the gpio drivers folder

lindi: just moves a file

MFD: pcf50633: Use mfd cells to register child devices MFD: pcf50633: Use mfd cells to register child devices

lindi: cleanup? No idea how tricky this really is

[edit] MFD: pcf50633: Use the genirq for irq handling

lindi: has again extra whitespace changes. I guess genirq is some more abstract way to handle IRQs? Can not really judge how tricky this is.

[edit] power: implement platform battery driver

lindi: feature. we can live without this if bq27x00 is mainlined or vice versa.

[edit] Define machine_is_neo1973_gta01()

lindi: trivial

[edit] glamo-mci: revert changes for Per's patchset

lindi: glamo stuff, no idea

[edit] nand/s3c2410: add mising badblocksbits value

lindi: bugfix. trivial. 
lindi: it seems this was broken in 2.6.36 and fixed again in 3.0.0 but differently: 26d9be11485ea8c1102c3e8eaa7667412eef4950

[edit] Openmoko resume reason sysfs node ported from 2.6.29

lindi: feature. I personally need this a lot so that I can differentiate between RTC and GSM wakeups

[edit] glamo-display: fix WSOD for 242 timming

lindi: openmoko specific. glamo hack. Who said 2-4-2 timings have no drawbacks? ;-)
gena2x: This is not original name for patch! And not true. I do not know why radek maned it with this way, but actually it JUST fixes WSOD with all kind of timings. Please rename it.

[edit] Enable powering off after 8s POWER press

lindi: openmoko specific. feature. simple. I personally don't really like this much however this should be easy to upstream.

[edit] gta02: add support for usb host mode

lindi: openmoko specific feature. looks quite simple.

[edit] ar6000_delay.patch

lindi: atheros wifi hack

[edit] wm8753: use snd_soc_jack on neo1973

lindi: openmoko specific. gta01-only?

[edit] Fix high power consumption in suspend

lindi: openmoko specific. bugfix. simple. this should be a good candidate for upstreaming first?
lindi: gena2x, this needs a better commit message

[edit] Force GPS power up on resume if it were powered up on suspend

lindi: openmoko specific. Is this needed at all with qi? (My guess is no, its resume path does not touch serial ports)

[edit] lis302dl accelerometer driver

lindi: openmoko specific. feature. hard to say how tricky this is. I can personally live without accelerometers.
Paul: upstream has a different driver for the hardware: http://lwn.net/Articles/304326/

[edit] input: lis302dl: fix the resume path

lindi: openmoko specific. bugfix to accelerometer support.

[edit] lis302dl: use ABS events rather then REL events

lindi: openmoko specific. bugfix to accelerometer support.

[edit] Fix compile error for gta02 accelerometer.

lindi: openmoko specific. trivial bugfix to accelerometer support. Why not rebase this to the patch?

[edit] tslib relies on ts pressures events so this hack is needed to get tslib stuff working

lindi: s3c specific. hack? I personally can live with evdev if this really only affects tslib.
Paul: hm, worth investigating more: is not returning pressure at all a valid thing to do for a TS driver?
Heiko Stübner <heiko@sntech.de>: 
 As I'm currently also working on a touchscreen driver I came upon a lot of
 discussion and documentation about the handling of pressure values.
 In the end a driver should not use the pressure property at all if it can't
 provide meaningfull pressure data (i.e. more than 0 and 1) and tslib should be
 "long fixed", if one does not use an ancient version.

[edit] touchscreen: ignore unexpected interrupts

lindi: s3c specific. bugfix? hard to say how ready this is for mainlining.

[edit] s3c2410_ts: jitter less touchscreen for glamo, version 4

lindi: openmoko specific. quite essential. hack: read ts during vblank?
gena2x: it slows down pixclock to read jitterless data. it does that while blank so screen has no artefacts. may be it is possible to do that while blank without slowing pixclock, even that we have no VSYNC-like interrupt we should be able to calculate exact time of VSYNC because pixclock is constant and we always know current position. But this doesn't solve only major concern of this patch - it introduces link (via callbacks) between glamo and ts.

[edit] wm8753: allow setting DAI mode even while pcm is active

lindi: bugfix. should be easy to mainline. This basically fixes a bug introduced in 338ee25393a5627e8ded5819147f98b919656ce9 that was mainlined to 2.6.39
lindi: is there some other driver that needs a similar fix? tlv320dac33.c seems to have a similar if (dac33->fifo_mode == ucontrol->value.integer.value[0]) return 0;
lindi: why does this return 1?
lindi: this seems to be called from snd_ctl_elem_write. If we return 1 then it calls snd_ctl_notify, what does this mean?
lindi-_> gena2x_ptr: "return 1" is a bug in that patch, it needs to be "return 0"
lindi-_> gena2x_ptr: easy to see
lindi-_> gena2x_ptr: strace alsamixer
lindi-_> gena2x_ptr: then while true; do alsactl restore -f somestate; done
lindi-_> gena2x_ptr: alsamixer gets spammed by bogus DAI change events
lindi-_> gena2x_ptr: no other alsa control sends notifications ion this test
lindi: sent upstream: http://mailman.alsa-project.org/pipermail/alsa-devel/2011-November/046036.html
lindi: ACCEPTED UPSTREAM: http://mailman.alsa-project.org/pipermail/alsa-devel/2011-November/046059.html

[edit] Workaround toolchain bug: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48783

lindi: trivial. Occurs with gcc 4.4 but not 4.6 anymore. No need to mainline :-)

[edit] First attempt at fixing openmoko bug #2478

lindi: openmoko specific. bugfix. not yet ready. See http://docs.openmoko.org/trac/ticket/2478
Personal tools

Random notes on SHR kernel patches (v2.6.39.4..shr-2.6.39-nodrm).

ARM: s3c24xx: Set ARCH_NR_GPIOS according to the selected SoC types.

lindi: bugfix/feature. sounds sensible. s3c specific

s3c24xx: Fix level irqs on external interrupts.

lindi: bugfix. s3c specific

mtd: s3c2410_nand: Add config option to disable hw ecc at runtime

lindi: feature. simple. I personally can live without nand. 

Add s3c24xx_serial_console_set_silence

lindi: What is this for? To allow using serial console and GSM on the same serial port? Who needs this anymore?

Add c fiq handler.

lindi: feature. tricky! Used by battery hdq queries (temperature, current, capacity etc.) and vibrator. Should just rewrite them in assembler?

Add glamo driver.

lindi: feature. tricky!! This does not include the DRM/3D bits but it is enough for me.

ARM: gta02: Add LED support

lindi: feature. openmoko specific. simple.

gta02: Disable hardware ECC unless we get instructed to enable it

lindi: openmoko specific. nand. simple.

gta02: Remove usage of pcf50633 gpio api

lindi: openmoko specific. cleanup.

s3c2440: gta02: Configure pcf50633 gpios.

lindi: openmoko specific.

ARM: s3c2440: GTA02: Select SPARSE_IRQ

lindi: openmoko specific. simple.

gta02: Add notify handler to probe device children

lindi: openmoko specific. feature.

gta02: Add bt power management device

lindi: openmoko specific. simple.

gta02: Add gps power management device

lindi: openmoko specific. simple.

gta02: Add gsm power management device

lindi: openmoko specific. simple.

gta02: Add wlan power management device

lindi: openmoko specific. simple.

gta02: Add glamo device

lindi: openmoko specific. relatively simple, real trouble is in the glamo driver itself

Add jbt device.

lindi: openmoko specific. backlight?

gta02: Add fiq handler

lindi: openmoko specific. depends on the tricky fiq support above.

gta02: Add battery driver

lindi: openmoko specific. depends on the tricky fiq support above.

gta02: add support for platform_battery

lindi: openmoko specific. simple.

Add atheros sdio ids.

lindi: trivial.

Add ar6000 wireless driver.

lindi: tricky! probably can never be mainlined. Maybe we can build it as a separate module package in debian?

Add jbt6k74 display driver.

lindi: feature. quite essential. does not look too tricky.

LEDS: leds-pwm: Add init, notfiy and exit callbacks

lindi: feature. not sure how easy this is to mainline

RTC: PCF50633: Don't request update IRQ

lindi: safe cleanup?

pcf50633-gpio: Add gpiolib support.

lindi: feature. has some useless whitespace changes. gpio stuff which I don't really understand

pcf50633: Move pcf50633-gpio driver to the gpio drivers folder

lindi: just moves a file

MFD: pcf50633: Use mfd cells to register child devices

lindi: cleanup? No idea how tricky this really is

MFD: pcf50633: Use the genirq for irq handling

lindi: has again extra whitespace changes. I guess genirq is some more abstract way to handle IRQs? Can not really judge how tricky this is.

power: implement platform battery driver

lindi: feature. we can live without this if bq27x00 is mainlined or vice versa.

Define machine_is_neo1973_gta01()

lindi: trivial

glamo-mci: revert changes for Per's patchset

lindi: glamo stuff, no idea

nand/s3c2410: add mising badblocksbits value

lindi: bugfix. trivial.

Openmoko resume reason sysfs node ported from 2.6.29

lindi: feature. I personally need this a lot so that I can differentiate between RTC and GSM wakeups

glamo-display: fix WSOD for 242 timming

lindi: openmoko specific. glamo hack. Who said 2-4-2 timings have no drawbacks? ;-)

Enable powering off after 8s POWER press

lindi: openmoko specific. feature. simple. I personally can live without this.

gta02: add support for usb host mode

lindi: openmoko specific feature. looks quite simple.

ar6000_delay.patch

lindi: atheros wifi hack

wm8753: use snd_soc_jack on neo1973

lindi: openmoko specific. gta01-only?

Fix high power consumption in suspend

lindi: openmoko specific. bugfix. simple.

Force GPS power up on resume if it were powered up on suspend

lindi: openmoko specific. Is this needed at all with qi? (My guess is no, its resume path does not touch serial ports)

lis302dl accelerometer driver

lindi: openmoko specific. feature. hard to say how tricky this is. I can personally live without accelerometers.

input: lis302dl: fix the resume path

lindi: openmoko specific. bugfix to accelerometer support.

lis302dl: use ABS events rather then REL events

lindi: openmoko specific. bugfix to accelerometer support.

Fix compile error for gta02 accelerometer.

lindi: openmoko specific. trivial bugfix to accelerometer support. Why not rebase this to the patch?

tslib relies on ts pressures events so this hack is needed to get tslib stuff working

lindi: s3c specific. hack? I personally can live with evdev if this really only affects tslib.

touchscreen: ignore unexpected interrupts

lindi: s3c specific. bugfix? hard to say how ready this is for mainlining.

s3c2410_ts: jitter less touchscreen for glamo, version 4

lindi: openmoko specific. quite essential. why does touchscreen depend on glamo?

wm8753: allow setting DAI mode even while pcm is active

lindi: bugfix. should be easy to mainline.

Workaround toolchain bug: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48783

lindi: trivial. Occurs with gcc 4.4 but not 4.6 anymore. No need to mainline :-)

First attempt at fixing openmoko bug #2478

lindi: openmoko specific. bugfix. not yet ready.